Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CreateCorpus obsolete? #68

Open
alexanderkoller opened this issue Jul 22, 2019 · 2 comments
Open

CreateCorpus obsolete? #68

alexanderkoller opened this issue Jul 22, 2019 · 2 comments
Labels
post-mrp-cleanup Cleanup tasks for after the MRP deadline

Comments

@alexanderkoller
Copy link
Contributor

Every CreateCorpus class we have also seems to have a sister class CreateCorpusParallel. Do we ever use the CreateCorpus classes? Could we simply delete them all? I worry that they are falling out of sync.

@namednil
Copy link
Contributor

That's a fair point. However, we need a non-parallel version for debugging of heuristics, otherwise the output is not interpretable because it blends messages from different graphs.

@alexanderkoller alexanderkoller added the post-mrp-cleanup Cleanup tasks for after the MRP deadline label Jul 22, 2019
@alexanderkoller
Copy link
Contributor Author

At least after the MRP deadline, let's get rid of the non-parallel versions. We can get sequential output if we fix the number of CPU cores to 1. Also, if we write error reports to files for the individual instance IDs, we can also work around the "blending" issue.

I see a really high risk of unexplainable bugs if we keep different versions of CreateCorpus around that duplicate so much code between each other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
post-mrp-cleanup Cleanup tasks for after the MRP deadline
Projects
None yet
Development

No branches or pull requests

2 participants