Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make concatenation of AMR files consistent in preprocessing #79

Open
jgroschwitz opened this issue Dec 5, 2019 · 1 comment
Open

make concatenation of AMR files consistent in preprocessing #79

jgroschwitz opened this issue Dec 5, 2019 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@jgroschwitz
Copy link
Contributor

Each AMR dataset (e.g. the dev set of LDC2017T10) consists of multiple files. In preprocessing, these files are concatenated in arbitrary order (determined by the OS). This order is not always consistent (I just had a case where one file from a first preprocessing run and a file from a different preprocessing run had different orders, leading to problems).

The concatenation should instead be consistent over different runs, e.g. by lexical ordering of filenames.

@jgroschwitz jgroschwitz added the bug Something isn't working label Dec 5, 2019
@jgroschwitz jgroschwitz self-assigned this Dec 5, 2019
@jgroschwitz
Copy link
Contributor Author

Also while at it, make sure to exclude hidden files from iteration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant