Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File extension for saveAs includes the codec name(s) #553

Closed
thijstriemstra opened this issue Mar 3, 2021 · 1 comment
Closed

File extension for saveAs includes the codec name(s) #553

thijstriemstra opened this issue Mar 3, 2021 · 1 comment

Comments

@thijstriemstra
Copy link
Member

thijstriemstra commented Mar 3, 2021

Description

After recording an audio/video using https://collab-project.github.io/videojs-record/demo/audio-video.html
and saving it using player.record().saveAs({'video': 'foo12'}) it presents the user with a filename of foo12.webm;codecs=vp8,opus. Before it didn't append the ;codecs=vp8,opus part.

Results

Expected

foo12.webm

Actual

foo12.webm;codecs=vp8,opus

Additional Information

Please include any additional information necessary here. Including the following:

versions

videojs

videojs-record 4.2.0, video.js 7.11.4

browsers

Google Chrome 89.0.4389.72

OSes

  • macOS Big Sur
  • Ubuntu 20.04
@thijstriemstra
Copy link
Member Author

thijstriemstra commented Mar 7, 2021

Turns out to be an issue in RecordRTC: muaz-khan/RecordRTC#731 and pull request: muaz-khan/RecordRTC#732

Update: fixed in recordrtc 5.6.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant