Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect type definition for clone() #288

Closed
lloydk opened this issue Feb 21, 2023 · 1 comment
Closed

Incorrect type definition for clone() #288

lloydk opened this issue Feb 21, 2023 · 1 comment

Comments

@lloydk
Copy link
Collaborator

lloydk commented Feb 21, 2023

I think the type definition for the clone function should be changed from

export default function clone(color: Color): Color;

to

export default function clone(color: ColorObject): ColorObject;

The clone method doesn't copy the spaceId property so ColorObject isn't 100% technically correct but it's more correct than Color.

I would have created a PR but I couldn't figure out how to get the type tests to run.

@lloydk
Copy link
Collaborator Author

lloydk commented Apr 12, 2023

This was fixed in #291.

@lloydk lloydk closed this as completed Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant