-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better error message when bitbucket rate limit is reached #81
Comments
Hitting this now. The NPM version of this package allows an option to use a CDN to install phantomjs, maybe that would be useful here? Additionally, it would be nice to pass in an option to avoid re-downloading phantomjs if the tar file already exists. I can make these changes once I get a few spare minutes. |
I've opened #84 which will raise an exception if the archive cannot be extracted. @taw what HTTP status code does Bitbucket return (I assume
|
@sshaw I don't remember. Someone needs to recheck that next time it's failing. I remember that my fix was working at that time ;-) |
Likely duplicate of #70. |
Currently
phantomjs
gem does this:wget
will return error code when it fails, so that makes sense, butcurl
won't - it will get 429 Rate Limit error, save html, and then try to "bunzip2" that, resulting in error message like:Passing
-f
tocurl
will "fix" that problem, and instead of failing with meaningless error message, it will raisewhich still leaves the problem of everybody's CIs failing transiently due to bitbucket rate limit error, but at least they'll fail with a meaningful error message.
Possible better "fix" for this would be to just retry loop 10 times with 1s in between or something like that, or try multiple sources (bitbucket→s3, github→s3 etc.), but this is a start.
The text was updated successfully, but these errors were encountered: