From d2a859a56fff10187915b92b762d72c4610f336c Mon Sep 17 00:00:00 2001 From: Tobias Roeser Date: Wed, 24 Aug 2022 13:03:11 +0200 Subject: [PATCH] Don't print unwanted debug messages - Multilogger prefers first logger (#2001) A better solution would be to add the `debugEnabled` flag to the constructor parameters of `MultiLogger`, but that would affect binary compatibilty. Pull request: https://github.com/com-lihaoyi/mill/pull/2001 --- main/util/src/mill/util/Loggers.scala | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/main/util/src/mill/util/Loggers.scala b/main/util/src/mill/util/Loggers.scala index ee97227da98..f013eeae592 100755 --- a/main/util/src/mill/util/Loggers.scala +++ b/main/util/src/mill/util/Loggers.scala @@ -235,6 +235,7 @@ class MultiStream(stream1: OutputStream, stream2: OutputStream) } }) +// TODO: make this a non-case class case class MultiLogger(colored: Boolean, logger1: Logger, logger2: Logger, inStream: InputStream) extends Logger { @@ -265,7 +266,8 @@ case class MultiLogger(colored: Boolean, logger1: Logger, logger2: Logger, inStr logger2.close() } - override def debugEnabled: Boolean = logger1.debugEnabled || logger2.debugEnabled + // TODO: this should be a ctr parameter, to let the user decide, but this affects binary compatibility + override def debugEnabled: Boolean = logger1.debugEnabled } /**