Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lost ability to install Mill for GHA when build.sc is not at the project root #2660

Closed
davesmith00000 opened this issue Jul 15, 2023 · 2 comments · Fixed by #2662
Closed
Milestone

Comments

@davesmith00000
Copy link
Contributor

davesmith00000 commented Jul 15, 2023

Hi,

I have a project that builds with a mix of Mill and sbt (for historical reasons), this means that neither sbt nor Mill live at the repo's root level. This worked fine we tried to upgrade to Mill 0.11.1, but now doesn't due to a recent change:

val msg = "build.sc file not found. Are you in a Mill project folder?"

(To answer to the question: "No, I'm not, but I will be." 😄)

The setup-mill action can no longer install Mill for us, producing this error:

image

I realise that...

  1. It will be suggested we use the bootstrap script thingy.
  2. I can probably fix this by placing a dummy build.sc at the root.
  3. This is an edge case, most people don't do this.

But I thought I'd raise the issue in case it was indicative of a wider problem. Feel free to close the issue based on any or all of the above reasons.

@lefou
Copy link
Member

lefou commented Jul 17, 2023

I think you discovered a bug. Mill should work without an existing build.sc, otherwise commands like init will no longer work. Thanks for reporting.

@lefou
Copy link
Member

lefou commented Jul 29, 2023

This should work again with the merge of #2662, which fixes the defunct version command. But I think using mill version could be replaced by mill --version which should return much faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants