Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signatures are not right in some scenarios #13

Open
wangjohnny opened this issue Aug 18, 2020 · 4 comments
Open

signatures are not right in some scenarios #13

wangjohnny opened this issue Aug 18, 2020 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@wangjohnny
Copy link

wangjohnny commented Aug 18, 2020

I found a bug in signatures.

  1. calling sign method.
    TxSigner.signStdTx(wallet: wallet, stdTx: stdTx);
  2. A bug in line 62 of the file named tx_signer.dart
    final signatureData = wallet.signTxData(bytes);
    The right return value is a list with length 64. But Sometimes this method return a list with length 63.
    An example:
    error value: 90fe20aea909ed11286468bd2b7e6c781d22e2df3fd2e0633ee16b2a3d7ea8f4 866a88d544df5dfb979a9b191e804155a64b94bd9cadcbbbaa7bb28e73f129
    The above value miss 00 in middle. The below is right value: 90fe20aea909ed11286468bd2b7e6c781d22e2df3fd2e0633ee16b2a3d7ea8f400866a88d544df5dfb979a9b191e804155a64b94bd9cadcbbbaa7bb28e73f129
@zenit70
Copy link
Collaborator

zenit70 commented Aug 27, 2020

@wangjohnny Thanks for reporting this bug.
We are investigating, will be fixed in the next Sacco.dart release.

@marcotradenet marcotradenet added the bug Something isn't working label Oct 16, 2020
@mekery
Copy link

mekery commented Mar 4, 2021

@zenit70 Is this bug fixed?

@zenit70
Copy link
Collaborator

zenit70 commented Mar 4, 2021

Hi @mekery,

i think so, have you tried the latest release?

If the problem was still here, to solve it we would need more information on how to reproduce.

Thanks

@wal33d006
Copy link

@zenit70 I am able to reproduce it. Do we have a plan on when to solve this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants