-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[package] boost/1.74.0: broken package_info when i18n_backend=icu #3895
Comments
Seems to work fine when not including the locale module: $ conan install boost/1.74.0@ -o boost:i18n_backend=icu -o boost:without_locale=True -o boost:without_log=True --build boost |
Can you check my pr?
This fails:
|
For both icu being shared or static, I get the same error as above for the current recipe. I get the following error for the pr's recipe when icu is static after boost builds:
icu's shared vs static configuration should probably be checked in boost's configure method and raised there. |
Oh, it works for me with a shared icu (with the boost from my pr #3872) The one from current master does not because it does not find iconv/icu. Indeed, it should throw an error when a static icu is used. |
Sorry, yes I did test a shared icu -- that's our default, so that's what gets tried first. Before components you definitely had locale when icu was shared. |
We're using Boost.Locale with a static ICU to do some conversions in a plugin. I'll try our project and report back. |
Built our product with the branch from #3872 and indeed Boost.Locale works with a static ICU. |
@datalogics-kam My build log contained the following:
which means boost could not build a test executable with icu. Only 5 minutes ago, I pushed a commit to #3872 that allows building (and testing) the Boost.Locale library. @ohanar |
@madebr I'm pretty sure it's linking; we were tracking code size changes when using ICU for Unicode case conversions. That's not to say that some other aspect of our project made it work. Tested again with the updates to #3872, and it works for us, still! |
@datalogics-kam |
@madebr Ah! It's macOS/Window/Linux and I was testing on macOS (primary development platform for me). Yes, we had to add
to our Conan profiles for Linux so that Boost could successfully probe for ICU. If this fixes that, it's a nice win! ETA: ...especially since our version of Artifactory fails to index packages that have options with |
@datalogics-kam |
@madebr Yes, the error that I saw before with a static icu now has now been resolved. |
@madebr Boost.Locale needs that to use ICU as a backend.
If the small testing program fails to build or run for any reason, then
|
Are you sure this is for boost locale? Isn't this for some other library? |
Yes, I'm sure of that. We had to set
The It's true that Boost.Locale doesn't specifically need C++11, it's more that it's a pass-through requirement of using ICU.
That's correct, the test is simple, but ICU requires C++ 11 since version 59, and the headers don't compile with an earlier standards level. |
I found it weird because neither the icu recipe neither boost checks for anything c++11 related. |
Just hit this one, what is the current status of this issue? |
See #3872 |
Everything builds just fine, but then the components fail validation:
The text was updated successfully, but these errors were encountered: