Fix/export case insensitive #8585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test error is not related to this PR I think:
|
uilianries
reviewed
Mar 2, 2021
conans/client/file_copier.py
Outdated
| @@ -145,6 +145,8 @@ def _filter_files(src, pattern, links, excludes, ignore_case, excluded_folders): | |||
| relative_path = os.path.relpath(root, src) | |||
| compare_relative_path = relative_path.lower() if ignore_case else relative_path | |||
| for exclude in excludes: | |||
| if ignore_case: | |||
| exclude = exclude.lower() | |||
There was a problem hiding this comment.
at line 121 it does the same.
Suggested change
| exclude = exclude.lower() | |
| exclude = exclude.lower() |
There was a problem hiding this comment.
good point. But need to remove the 2 lines.
czoido
pushed a commit
to czoido/conan
that referenced
this pull request
Mar 9, 2021
* export was case sensitive * add more checks * fixing tests * fixing more tests * removed repeated code * removed repeated code
czoido
added a commit
that referenced
this pull request
Mar 9, 2021
* export was case sensitive * add more checks * fixing tests * fixing more tests * removed repeated code * removed repeated code Co-authored-by: James <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Restoring the behavior that
exportsandexports_sourceswere case sensitive by default.Docs: Omit
Close #8583
It is possible that this might be breaking, lets see.
#tags: slow