Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove exact eigen requirement #23

Closed
wants to merge 2 commits into from
Closed

Remove exact eigen requirement #23

wants to merge 2 commits into from

Conversation

Tobias-Fischer
Copy link
Contributor

@Tobias-Fischer Tobias-Fischer commented Sep 19, 2021 •
edited
Loading

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

See #19 for reasoning. Basically ceres requires that Eigen is unnecessarily the exact same version when compiling downstream pacakges. Fix #19

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@Tobias-Fischer
Copy link
Contributor Author

@conda-forge-admin, please rerender

@Tobias-Fischer
Copy link
Contributor Author

/cc @traversaro

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.

@Tobias-Fischer Tobias-Fischer mentioned this pull request Sep 19, 2021
Closed
5 tasks
@jschueller
Copy link
Contributor

I'm not too sure on this: upstream added this for a reason, why not ask them if it can be removed ?

@traversaro
Copy link

traversaro commented Sep 20, 2021 •
edited
Loading

I'm not too sure on this: upstream added this for a reason, why not ask them if it can be removed ?

This is a good idea, I can open an issue upstream later today (CEST).

@Tobias-Fischer
Copy link
Contributor Author

Checking with upstream is probably a good idea. In this case, while we wait to hear back, shall we merge in #22 so we resolve issues downstream in the meantime?

@traversaro traversaro mentioned this pull request Sep 20, 2021
Closed
@jschueller jschueller closed this Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traversaro traversaro traversaro approved these changes

@jschueller jschueller Awaiting requested review from jschueller

@seanyen seanyen Awaiting requested review from seanyen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Eigen version issue
4 participants
@Tobias-Fischer @conda-forge-linter @jschueller @traversaro