Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builds broken #249

Closed
twiecki opened this issue May 16, 2024 · 6 comments
Closed

Builds broken #249

twiecki opened this issue May 16, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@twiecki
Copy link

twiecki commented May 16, 2024

Seems like builds have been broken and jaxlib is not getting updated the last few versions.

image

@jezdez @djsutherland @msarahan

@twiecki
Copy link
Author

twiecki commented May 17, 2024

CC
@ericmjl
@ngam
@xhochy

@xhochy
Copy link
Member

xhochy commented May 17, 2024

Please fix them, not need to open an issue for this.

@xhochy xhochy closed this as not planned Won't fix, can't repro, duplicate, stale May 17, 2024
@twiecki
Copy link
Author

twiecki commented May 17, 2024

I thought the issue tracker here is used to highlight and keep track of issues. A PR (which could come from anybody, and doesn't exist yet) can then reference and close the issue. Issues in other projects that are blocked by this can reference this issue (as happened above) to keep track of things. Apologies if I misunderstood what the issue tracker is for here.

@xhochy
Copy link
Member

xhochy commented May 17, 2024

We usually only use the failing PRs as a way to communicate about such things. Issues are typically used for raising issues about failures in already built packages, e.g. missing files in a package.

Currently, this is mostly stuck on people rebasing the jaxlib patches on every version. This is sadly a bit time-intensive as:

  1. The patches are sometimes on top of XLA and will in the end be patches-in-patches
  2. The feedback cycle is really slow as you need to wait hours to see whether the patches actually work.

@twiecki
Copy link
Author

twiecki commented May 17, 2024

@xhochy Understood 👍. Sounds like a cumbersome process indeed.

@xhochy
Copy link
Member

xhochy commented May 17, 2024

Most likely we will see some progress next week in #248, best to link to this then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants