Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove python-json-logger and jupyter_Client from conda run requirements #37

Closed
rxm7706 opened this issue Jun 19, 2023 · 2 comments
Closed

Comments

@rxm7706
Copy link
Contributor

rxm7706 commented Jun 19, 2023

current conda recipe has a limit on jupyter_client -- - jupyter_client >=5.1,<7.0

https://github.com/conda-forge/kedro-feedstock/blob/cd4469b872c848a0d1b8a53362c47d106788977b/recipe/meta.yaml#LL35C1-L35C32

  1. As a part Remove .ipython dir and introduce kedro Jupyter kernel kedro-org/kedro#1355 - Remove .ipython dir and introduce kedro Jupyter kernel kedro-org/kedro#1355 (comment)
    kedro removed jupyter_client altogether - from requirements.txt
  2. python-json-logger was also removed as a part Improve IPython extension error handling kedro-org/kedro#1761 - kedro-org/kedro@f3aa285#r938767423
  3. build was added recently
  4. match pip-tools and rich limits

We should either remove it completely - or atleast increase the limit to allow newer versions of Jupyter_client

@astrojuanlu
Copy link
Member

Good catch @rxm7706. Pull requests welcome, otherwise we'll look into this soon.

- jupyter_client >=5.1,<7.0

@rxm7706
Copy link
Contributor Author

rxm7706 commented Jun 19, 2023

I'll raise a PR soon, seems like we also added build to requirements

@rxm7706 rxm7706 changed the title Remove or increase upper limit of Jupyter_Client from conda run requirements Remove python-json-logger and jupyter_Client from conda run requirements Jun 19, 2023
@rxm7706 rxm7706 closed this as completed Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants