Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Django dependency #39

Open
1 task done
zklaus opened this issue Sep 13, 2022 · 0 comments · May be fixed by #40
Open
1 task done

Remove Django dependency #39

zklaus opened this issue Sep 13, 2022 · 0 comments · May be fixed by #40
Labels

Comments

@zklaus
Copy link

zklaus commented Sep 13, 2022

Solution to issue cannot be found in the documentation.

  • I checked the documentation.

Issue

In be2cf3e, a hard dependency on Django was introduced by @jakirkham. I'd like to get rid of it again.

It is true that this package is not functional without Django, however, it is quite likely to be installed even in environments that don't make use of Django. This is because it is a dependency of Prospector, but could in general be pulled in by various Pylint setups.

Removing the dependency here would have the upside that such use would not needlessly pull in the heavy Django. It would also facilitate the use of this package together with a local development installation of Django. The downside is that the user has to depend on Django separately for this package to work, however, this is likely the case anyway, since the project that the user wants to check will rely on Django. Indeed, in this sense the dependency here might mask a missing dependency in the downstream project's setup.

@jakirkham, @conda-forge/pylint-django, what do you think?

Installed packages

-

Environment info

-
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant