Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --with-tzpath setting #403

Open
isuruf opened this issue Oct 28, 2020 · 3 comments
Open

Remove --with-tzpath setting #403

isuruf opened this issue Oct 28, 2020 · 3 comments

Comments

@isuruf
Copy link
Member

isuruf commented Oct 28, 2020

The conda location is supposed to be appended instead of overriding.

cc @ocefpaf, @mbargull

@mbargull
Copy link
Member

Why not prepend? (And if we prepend, we could as well override as currently is.)

@isuruf
Copy link
Member Author

isuruf commented Oct 28, 2020

I can't remember the reason, but there was some discussion as to what to do. cc @ocefpaf, @mingwandroid

@ocefpaf
Copy link
Member

ocefpaf commented Oct 28, 2020

Why not prepend? (And if we prepend, we could as well override as currently is.)

Yep. We could pre-pended but then that would not really make a difference b/c our path would always be present since our tzdata is a Python dependency.

The pep does suggests to append but, b/c we do have our own tzdata, overriding it not that bad. That was modeled after a build without tzdata as a dependency or as an optional dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants