From 89ccae185ebfd9303e47ff016dc5a3b91902ec68 Mon Sep 17 00:00:00 2001 From: Amir Mohammadi <183.amir@gmail.com> Date: Wed, 4 May 2016 23:47:16 +0200 Subject: [PATCH 1/6] Create PULL_REQUEST_TEMPLATE.md --- PULL_REQUEST_TEMPLATE.md | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) create mode 100644 PULL_REQUEST_TEMPLATE.md diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 0000000000000..c11abfbc3615e --- /dev/null +++ b/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,37 @@ +Recipes added with this pull request (max 5): + + - package1 + - package2 + +I have checked the following in my recipes: +* [ ] My files end with only 1 newline character, no more, no less. +* [ ] My recipe follow the same style as [example](https://github.com/conda-forge/staged-recipes/blob/master/recipes/example/meta.yaml) as much as possible. +* [ ] The license field also specifies the number of the license if applicable (e.g. `GPLv3` instead of `GPL` or `BSD 3-clause` instead of `BSD`). +* [ ] My recipe has tests. +* [ ] I have looked at [pinned packages](https://github.com/conda-forge/staged-recipes/wiki/Pinned-dependencies) and pinned those packages as stated. +* [ ] The `summary` just explains the package and does not include the package name. (e.g. Instead of saying `Jupyterhub is a multi-user server for Jupyter notebooks` just say `Multi-user server for Jupyter notebooks`) + +If you build for Windows too: +* [ ] I have read [VC features](https://github.com/conda-forge/staged-recipes/wiki/VC-features) + +If recipe uses make: +* [ ] I have also added `make check` or similar if applicable. + +If recipe builds a library: +* [ ] I have enabled both static and shared libraries. + +If recipe builds some C/C++ code: +* [ ] I have not included `gcc` or `libgcc` in `requirements`. Exceptions can be made but must be tested first with `gcc`/`clang` that is already installed in our CI machines. + +If it is Python Pypi package: +* [ ] I have used `pip` to install it and my recipe has these elements: +```yaml +build: + script: pip install --no-deps . +requirements: + build: + - python + - pip + run: + - python +``` From 33e9408583cd222c8a43e737cbaabaf4a6fe97bb Mon Sep 17 00:00:00 2001 From: Amir Mohammadi <183.amir@gmail.com> Date: Wed, 4 May 2016 23:52:48 +0200 Subject: [PATCH 2/6] Update PULL_REQUEST_TEMPLATE.md --- PULL_REQUEST_TEMPLATE.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md index c11abfbc3615e..39b6dcb910996 100644 --- a/PULL_REQUEST_TEMPLATE.md +++ b/PULL_REQUEST_TEMPLATE.md @@ -14,16 +14,16 @@ I have checked the following in my recipes: If you build for Windows too: * [ ] I have read [VC features](https://github.com/conda-forge/staged-recipes/wiki/VC-features) -If recipe uses make: +If recipe uses make or cmake or ctest: * [ ] I have also added `make check` or similar if applicable. If recipe builds a library: * [ ] I have enabled both static and shared libraries. -If recipe builds some C/C++ code: +If recipe builds some C/C++, Fortran or OMP code: * [ ] I have not included `gcc` or `libgcc` in `requirements`. Exceptions can be made but must be tested first with `gcc`/`clang` that is already installed in our CI machines. -If it is Python Pypi package: +If it is Python PyPI package: * [ ] I have used `pip` to install it and my recipe has these elements: ```yaml build: From 4ae2969819d85f37e50a7e33f9819fd686b80eb3 Mon Sep 17 00:00:00 2001 From: Amir Mohammadi <183.amir@gmail.com> Date: Wed, 4 May 2016 23:53:45 +0200 Subject: [PATCH 3/6] Rename PULL_REQUEST_TEMPLATE.md to .github/PULL_REQUEST_TEMPLATE.md [skip ci] --- PULL_REQUEST_TEMPLATE.md => .github/PULL_REQUEST_TEMPLATE.md | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename PULL_REQUEST_TEMPLATE.md => .github/PULL_REQUEST_TEMPLATE.md (100%) diff --git a/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md similarity index 100% rename from PULL_REQUEST_TEMPLATE.md rename to .github/PULL_REQUEST_TEMPLATE.md From aaf53d9590859a64b1314958b887e176196fbffb Mon Sep 17 00:00:00 2001 From: Amir Mohammadi <183.amir@gmail.com> Date: Wed, 4 May 2016 23:57:07 +0200 Subject: [PATCH 4/6] Update PULL_REQUEST_TEMPLATE.md [skip ci] --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 39b6dcb910996..1c0493894396d 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -23,7 +23,7 @@ If recipe builds a library: If recipe builds some C/C++, Fortran or OMP code: * [ ] I have not included `gcc` or `libgcc` in `requirements`. Exceptions can be made but must be tested first with `gcc`/`clang` that is already installed in our CI machines. -If it is Python PyPI package: +If it is a Python PyPI package: * [ ] I have used `pip` to install it and my recipe has these elements: ```yaml build: From 99c0472f3703a60788f1553b9a49827936a006ac Mon Sep 17 00:00:00 2001 From: Amir Mohammadi <183.amir@gmail.com> Date: Mon, 16 May 2016 00:48:27 +0200 Subject: [PATCH 5/6] fixes --- .github/PULL_REQUEST_TEMPLATE.md | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 1c0493894396d..1645ac2e6d663 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,4 +1,4 @@ -Recipes added with this pull request (max 5): +Recipes added with this pull request (We prefer to have one pull request per package): - package1 - package2 @@ -12,7 +12,7 @@ I have checked the following in my recipes: * [ ] The `summary` just explains the package and does not include the package name. (e.g. Instead of saying `Jupyterhub is a multi-user server for Jupyter notebooks` just say `Multi-user server for Jupyter notebooks`) If you build for Windows too: -* [ ] I have read [VC features](https://github.com/conda-forge/staged-recipes/wiki/VC-features) +* [ ] I have read [VC features](https://github.com/conda-forge/staged-recipes/wiki/VC-features) and implemented. If recipe uses make or cmake or ctest: * [ ] I have also added `make check` or similar if applicable. @@ -20,18 +20,18 @@ If recipe uses make or cmake or ctest: If recipe builds a library: * [ ] I have enabled both static and shared libraries. -If recipe builds some C/C++, Fortran or OMP code: +If recipe builds some C/C++: * [ ] I have not included `gcc` or `libgcc` in `requirements`. Exceptions can be made but must be tested first with `gcc`/`clang` that is already installed in our CI machines. If it is a Python PyPI package: -* [ ] I have used `pip` to install it and my recipe has these elements: +* [ ] I have used `python` to install it and my recipe has these elements: ```yaml build: - script: pip install --no-deps . + script: python setup.py install --single-version-externally-managed --record=record.txt requirements: build: - python - - pip + - setuptools run: - python ``` From 6d19f415d0daba6498545cac87d2e9462ea652c4 Mon Sep 17 00:00:00 2001 From: Amir Mohammadi <183.amir@gmail.com> Date: Mon, 16 May 2016 00:53:45 +0200 Subject: [PATCH 6/6] Add nosetests [skip ci] --- .github/PULL_REQUEST_TEMPLATE.md | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 1645ac2e6d663..0cee4c9f808ef 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -35,3 +35,12 @@ requirements: run: - python ``` +* [ ] Test commands such as `nosetests package` or `py.test` are added: +```yaml +test: + requires: + - nose + + commands: + - nosetests -sv package +```