Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Cannot log out via http://localhost:8080/conda-store/ #684

Closed
nkaretnikov opened this issue Dec 4, 2023 · 5 comments
Closed

[BUG] - Cannot log out via http://localhost:8080/conda-store/ #684

nkaretnikov opened this issue Dec 4, 2023 · 5 comments
Labels
impact: high 🟥 This issue affects most of the conda-store users or is a critical issue type: bug 🐛 Something isn't working

Comments

@nkaretnikov
Copy link
Contributor

nkaretnikov commented Dec 4, 2023

Describe the bug

  • Go to this URL (note: it's the server port)
  • Click on "Log out"
  • Get redirected to the same page, not logged out.

Expected behavior

Being able to log out.

Logging out via the UI URL works fine: http://localhost:8000/.

This is important for the jupyterlab-conda-store extension.
It uses only the server URL/ports.
So you're able to log in but not log out.
I've just tested this on Nebari using Keycloak auth as well as with standalone conda-store and jupyterlab-conda-store.

How to Reproduce the problem?

See above.

Output

No response

Versions and dependencies used.

4ed688a - server
4f245dc on top of 1d56d42 - jlab extension

Anything else?

No response

@nkaretnikov nkaretnikov added the type: bug 🐛 Something isn't working label Dec 4, 2023
@kcpevey
Copy link
Contributor

kcpevey commented Dec 5, 2023

I tested on Nebari v2023.11.0, on the react app not the jlab extension. Not sure what the conda-store version is, but I believe its the latest release.

I can confirm that clicking the Log out button produces some network traffic, the page looks like it reloads, but I am still logged in (Can still see all the environments and the button is still in "Log out" state. No errors in the js console.

@pavithraes pavithraes added the impact: high 🟥 This issue affects most of the conda-store users or is a critical issue label Jan 15, 2024
@kcpevey
Copy link
Contributor

kcpevey commented Apr 3, 2024

I can confirm that this is an issue in the react app and the extension in the 2024.3.1 release.

@gabalafou
Copy link
Contributor

gabalafou commented Sep 11, 2024

Oddly, I cannot reproduce this. Steps I followed:

  1. Pulled latest from conda-store-ui: conda-incubator/conda-store-ui@e93a6c1
  2. yarn install
  3. yarn start
  4. Go to http://localhost:8080/conda-store/
    • This is the server-vendored version of the UI, which shows "Version: 2024.3.1" in the lower left
    • If I go to http://localhost:8000/ (port 8000 not 8080), I see "Version: 2024.6.1"
    • The log in/out button is in the log in state
  5. Click "Log in" button in top left
  6. Get taken to login form at URL http://localhost:8080/conda-store/login/?next=http://localhost:8080/conda-store/
  7. Log in with default username and password
  8. Get taken back to http://localhost:8080/conda-store/, the green button in the upper right says "Log out"
  9. Click the Log out button
  10. Get taken back to http://localhost:8080/conda-store/ and I am logged out

I can repeat these same steps for port 8000 (version 2024.6.1) and I get the same results.

@peytondmurray
Copy link
Contributor

peytondmurray commented Sep 11, 2024

I tried to reproduce this on conda-store 3f51452 as well, but cannot:

  1. docker compose up --build; waited for everything to start
  2. Logged in via localhost:8080/conda-store
  3. Created new environment in my username namespace; waited for it to finish.

image (1)

  1. Logged out. Cannot see the new environment I just made

image (2)

@kcpevey
Copy link
Contributor

kcpevey commented Sep 11, 2024

This means that either changes to main have resolved this issue, or this is an issue with how Nebari is handling the logout/authentication. Given that nebari auth is routed through keycloak, this seems the more likely reason. We can close this and I'll open up an issue on Nebari to investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact: high 🟥 This issue affects most of the conda-store users or is a critical issue type: bug 🐛 Something isn't working
Projects
Archived in project
Development

No branches or pull requests

5 participants