Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installer-url option triggers an error on windows #97

Closed
rvianello opened this issue Nov 16, 2020 · 3 comments · Fixed by #98
Closed

installer-url option triggers an error on windows #97

rvianello opened this issue Nov 16, 2020 · 3 comments · Fixed by #98
Assignees
Labels
type:bug Something isn't working
Milestone

Comments

@rvianello
Copy link

I'm trying to use the miniforge distribution, it works just as expected for linux and osx, but on windows it fails when trying to cache the downloaded installer, and it logs the following output:

# 
# Downloading Custom Installer...

#####################################

Miniforge3-Windows-x86_64.exe
Saving cache...
Error: EINVAL: invalid argument, mkdir 'C:\hostedtoolcache\windows\https:\github.com\conda-forge\miniforge\releases\latest\download\Miniforge3-Windows-x86_64.exe\https:\github.com\conda-forge\miniforge\releases\latest\download\Miniforge3-Windows-x86_64.exe\x64'

I suspect the error could be due to the additional : characters in the directory path, coming from the url schema?

Thanks a lot for developing this action,

Best,
Riccardo

@bollwyvl
Copy link
Contributor

bollwyvl commented Nov 16, 2020 via email

@rvianello
Copy link
Author

Thanks a lot for the very quick fix!

@bollwyvl
Copy link
Contributor

Thanks for bringing it to our attention... I feel there's a bit of a sea change coming, and we'll be seeing more custom installers in the future.... 🚝

@bollwyvl bollwyvl mentioned this issue Nov 19, 2020
8 tasks
@goanpeca goanpeca modified the milestones: v2.1.0, v2.0.1 Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants