Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish stable artifacts with checksums during release #5340

Closed
2 tasks done
jakirkham opened this issue May 13, 2024 · 2 comments · Fixed by #5339
Closed
2 tasks done

Publish stable artifacts with checksums during release #5340

jakirkham opened this issue May 13, 2024 · 2 comments · Fixed by #5339
Labels
in-progress issue is actively being worked on locked [bot] locked due to inactivity source::community catch-all for issues filed by community members type::task indicates a change that doesn't pertain to the code itself, e.g. updating CI/CQ, rebuilding package

Comments

@jakirkham
Copy link
Member

jakirkham commented May 13, 2024

Checklist

  • I added a descriptive title
  • I searched open requests and couldn't find a duplicate

What is the idea?

Currently GH provides autogenerated archives with releases. However these have the downside of having unstable checksums. As a result, when they are used as a source in package builds (like in conda-forge), they may pass at one point in time and later fail due to checksum mismatches

Given this, wonder if we can consider a different option where an artifact is generated and uploaded as part of the release process with a checksum. That way consumers of these artifacts will know the artifacts are static and have a checksum they can count on to verify those artifacts

Why is this needed?

Would improve downstream packaging experience by providing better reliability

What should happen?

Am a little unsure what the current release process looks like. So what should be done will depend a bit on how that release process is run

Do see that we have a Rever file. If that is what we are using, we could specify $GHRELEASE_ASSETS (like in conda-smithy)

If we are not using Rever, maybe we could use a GH Actions step to upload artifacts

There might be other reasonable choices depending on what fits best in our release process

Additional Context

Recently ran into this when releasing 24.5.0 ( conda-forge/conda-build-feedstock#226 ). Though this is not the first time we have seen this issue with GH autogenerated artifacts

Also a similar issue occurred with Conda ( conda/conda#13399 ). Maybe the solution applied there ( conda/conda#13663 ) can be added here

@jakirkham jakirkham mentioned this issue May 13, 2024
3 tasks
@jakirkham
Copy link
Member Author

cc @kenodegard (for vis)

@kenodegard
Copy link
Contributor

@jakirkham thanks for opening this and linking to the original issue in conda/conda

@kenodegard kenodegard added type::task indicates a change that doesn't pertain to the code itself, e.g. updating CI/CQ, rebuilding package source::community catch-all for issues filed by community members in-progress issue is actively being worked on labels May 13, 2024
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Nov 10, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
in-progress issue is actively being worked on locked [bot] locked due to inactivity source::community catch-all for issues filed by community members type::task indicates a change that doesn't pertain to the code itself, e.g. updating CI/CQ, rebuilding package
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants