Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIs throwing 500 status when 4** is expected #172

Open
pyarun opened this issue May 28, 2024 · 4 comments
Open

APIs throwing 500 status when 4** is expected #172

pyarun opened this issue May 28, 2024 · 4 comments
Assignees

Comments

@pyarun
Copy link

pyarun commented May 28, 2024

Describe the bug
When trying to delete a non-existing workflow using DELETE {{conductorBaseUrl}}/api/metadata/workflow/:name/:version api
replies back with 500 status code.

{
    "status": 500,
    "message": "No such workflow definition: memes_maker version: 2",
    "instance": "1a79daf01f84",
    "retryable": false
}

Details
Conductor version: v3.19.0
Persistence implementation: Postgres
Queue implementation: Postgres
Lock: I guess redis

To Reproduce
Steps to reproduce the behavior:

  1. Use API to delete non existing workflow
curl --location --request DELETE 'http://localhost8080/api/metadata/workflow/memes_maker/2' 
  1. See error

Expected behavior
Status code should be 404

Additional context
Same thing happens if we try to create existing workflow with existing version.

@pyarun pyarun changed the title APIs througing 500 status when 4** is expected APIs throwing 500 status when 4** is expected May 28, 2024
@v1r3n
Copy link
Collaborator

v1r3n commented Jun 20, 2024

Hi @pyarun are you using postgres as a backend?

@pyarun
Copy link
Author

pyarun commented Jun 20, 2024

Hi @pyarun are you using postgres as a backend?

yes

@prathamjagga
Copy link
Contributor

In both postgres and redis, NotFoundException is thrown, but in the redis the API gives 4XX error code. need to look what is happening wrong here.

@shrimank
Copy link

shrimank commented Oct 16, 2024

Same issue I am checking in latest version v3.21.6, expected 404 receiving 500 Http status code
#bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants