From 030f214714074b178734ce48b980e08512972cfd Mon Sep 17 00:00:00 2001 From: bvarghese1 Date: Tue, 26 Apr 2022 17:10:51 -0700 Subject: [PATCH] feat: enable max/min udaf for string & bytes data types - The max and min udaf was generalized to handle date & time data types See - 51343934507e7f84c477dde00370fd0b2b35786b - As a result, the code was capable of supporting string and bytes data types - This commit simply enables them in the max and min udaf's --- .../confluent/ksql/function/udaf/max/MaxAggFunctionFactory.java | 2 ++ .../confluent/ksql/function/udaf/min/MinAggFunctionFactory.java | 2 ++ 2 files changed, 4 insertions(+) diff --git a/ksqldb-engine/src/main/java/io/confluent/ksql/function/udaf/max/MaxAggFunctionFactory.java b/ksqldb-engine/src/main/java/io/confluent/ksql/function/udaf/max/MaxAggFunctionFactory.java index 7fa8b1dcd121..1b7eb4f6be05 100644 --- a/ksqldb-engine/src/main/java/io/confluent/ksql/function/udaf/max/MaxAggFunctionFactory.java +++ b/ksqldb-engine/src/main/java/io/confluent/ksql/function/udaf/max/MaxAggFunctionFactory.java @@ -52,6 +52,8 @@ public KsqlAggregateFunction createAggregateFunction( case DATE: case TIME: case TIMESTAMP: + case STRING: + case BYTES: return new MaxKudaf(FUNCTION_NAME, initArgs.udafIndex(), argSchema); default: throw new KsqlException( diff --git a/ksqldb-engine/src/main/java/io/confluent/ksql/function/udaf/min/MinAggFunctionFactory.java b/ksqldb-engine/src/main/java/io/confluent/ksql/function/udaf/min/MinAggFunctionFactory.java index 0445cde96e27..7b7285be0de5 100644 --- a/ksqldb-engine/src/main/java/io/confluent/ksql/function/udaf/min/MinAggFunctionFactory.java +++ b/ksqldb-engine/src/main/java/io/confluent/ksql/function/udaf/min/MinAggFunctionFactory.java @@ -51,6 +51,8 @@ public KsqlAggregateFunction createAggregateFunction( case DATE: case TIME: case TIMESTAMP: + case STRING: + case BYTES: return new MinKudaf(FUNCTION_NAME, initArgs.udafIndex(), argSchema); default: throw new KsqlException(