From 64b98470a960119c9b8d73c7c8c1a29cc1b8c9e4 Mon Sep 17 00:00:00 2001
From: Vicky Papavasileiou <vpapavasileiou@confluent.io>
Date: Tue, 3 Sep 2019 10:09:24 -0700
Subject: [PATCH] reverted pom changes, applied almog's comments

---
 ksql-engine/pom.xml                           |   8 --------
 .../io/confluent/ksql/function/UdfLoader.java |   5 +++--
 .../src/test/resources/udf-failing-tests.jar  | Bin 5019 -> 5017 bytes
 3 files changed, 3 insertions(+), 10 deletions(-)

diff --git a/ksql-engine/pom.xml b/ksql-engine/pom.xml
index a5076b52e892..ecef4f9c1781 100644
--- a/ksql-engine/pom.xml
+++ b/ksql-engine/pom.xml
@@ -167,14 +167,6 @@
             <artifactId>wiremock-jre8</artifactId>
             <scope>test</scope>
         </dependency>
-      <dependency>
-        <groupId>io.confluent.ksql</groupId>
-        <artifactId>ksql-streams</artifactId>
-      </dependency>
-        <dependency>
-            <groupId>io.confluent.ksql</groupId>
-            <artifactId>ksql-streams</artifactId>
-        </dependency>
 
     </dependencies>
 
diff --git a/ksql-engine/src/main/java/io/confluent/ksql/function/UdfLoader.java b/ksql-engine/src/main/java/io/confluent/ksql/function/UdfLoader.java
index a815b1ec1c59..36f342c091b4 100644
--- a/ksql-engine/src/main/java/io/confluent/ksql/function/UdfLoader.java
+++ b/ksql-engine/src/main/java/io/confluent/ksql/function/UdfLoader.java
@@ -405,8 +405,9 @@ private Function<List<Schema>,Schema> handleUdfSchemaProviderAnnotation(
     final Object instance = instantiateUdfClass(theClass, annotation);
 
     return parameterSchemas -> {
-      final List<SqlType> parameterTypes = parameterSchemas.stream().map(p -> SchemaConverters
-          .connectToSqlConverter().toSqlType(p)).collect(Collectors.toList());
+      final List<SqlType> parameterTypes = parameterSchemas.stream()
+          .map(p -> SchemaConverters.connectToSqlConverter().toSqlType(p))
+          .collect(Collectors.toList());
       return SchemaConverters.sqlToConnectConverter().toConnectSchema(invokeSchemaProviderMethod(
           instance, m, parameterTypes, annotation));
     };
diff --git a/ksql-engine/src/test/resources/udf-failing-tests.jar b/ksql-engine/src/test/resources/udf-failing-tests.jar
index dc8925ce90ca172b769615e24166167a4fa9495b..f96cfa98040b2515bb44f4860eee33b734902365 100644
GIT binary patch
delta 396
zcmbQOK2x1Hz?+$civa{Sc`8rjRbk!;q)e89sk`!E>c1L@nykU74W`2w^+ELJ4#pEq
zU`8;D353zbrUhn9-p=6$l3B#b#0)fbGBdXpm^R?H1JRocx$~Jgfee4q*X36VC%@zk
zsNcwS$UuPMf^B@^g`J9q7F#a(PT*@wsDEHGy&z(8l_%G~y|VJ_cLymQ^pcxrzvH2w
zXQ{Vx#RaxwjgoG!-OAg3r#4RB*nG>A>$yp!sOt9IZ^6@6*w#r*uABaT)ogyQr9}tA
zZGR=mPYCzhxIQE+us*<>kx7IZ?r;CeyZDU3p8LRO52lUy!JeF)!fyuV&*irU)3^B{
z^0ESvV1A`QESSD2kOijQ1RcS2m!LJ+%O?b_z%;9nAD9jkI)&tOP2n826?~w;2LO!I
BhyMTo

delta 398
zcmbQKK3knPz?+$civa|-#K=zMRbk!?q)e7EgLrr4!PI{>5H(qYQ5#H$G3tZp%^i#<
zn81u+783}gi%p9Oq<`{u4mS|Jh!ZS6nVDM)tkZzo4y>V&JD-UYXoP=Wgr{op<d?hw
z^?SJv83-^u_&e{>g5u^(cF%>)3LVZ1o#P*vOqa;fpEbWJKmU0D`kfmK79A3kx1W=d
z-k4Syx+kQ6uH)MFe>Pv(p1*Fo>nVN1@~J@Tl?TCV=I@qG{&eb+n8y|C`tZ=T%wDP%
zRnr#pZ|gfGb!2;M@yQSD0p5&EBFr$KGXmYrX99NnJ3f1eWBI|}oSejO2IkM^w+7QU
z`62Ss0+C>Txj-zKzAlgj*6$+d2&Ov(A?l9_T7l)6h5W#Dh|nn{zpD%9u&v?)1wQ~(
Ctc-U6