Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete consumer groups when a query is terminated #1283

Closed
apurvam opened this issue May 7, 2018 · 3 comments · Fixed by #6160
Closed

Delete consumer groups when a query is terminated #1283

apurvam opened this issue May 7, 2018 · 3 comments · Fixed by #6160
Assignees
Labels
enhancement good first issue P0 Denotes must-have for a given milestone
Milestone

Comments

@apurvam
Copy link
Contributor

apurvam commented May 7, 2018

Right now, when a query is terminated, we use the streams reset tool which just resets the committed offsets for the consumer group used by the application id.

However, for KSQL, the consumer group should really be deleted.

Now that KIP-222 is available (https://cwiki.apache.org/confluence/display/KAFKA/KIP-222+-+Add+Consumer+Group+operations+to+Admin+API), we can delete the consumer group once terminate is called using the Java AdminClient.

@big-andy-coates
Copy link
Contributor

+1

@big-andy-coates big-andy-coates added the P1 Slightly lower priority to P0 ;) label Jun 30, 2020
@big-andy-coates
Copy link
Contributor

Marking as P1 as all these consumer groups show up in UIs, making it hard for people to find the actual valid / live consumer groups.

@apurvam
Copy link
Contributor Author

apurvam commented Aug 31, 2020

Bumping this up to a p0, as it has come up multiple times now in the last few weeks and is causing quite a lot of confusion.

@apurvam apurvam added P0 Denotes must-have for a given milestone and removed P1 Slightly lower priority to P0 ;) labels Aug 31, 2020
@agavra agavra self-assigned this Aug 31, 2020
@agavra agavra added this to the 0.13.0 milestone Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue P0 Denotes must-have for a given milestone
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants