Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Queries: Heartbeat: Replace TreeMap with List #4277

Closed
vpapavas opened this issue Jan 10, 2020 · 1 comment
Closed

Pull Queries: Heartbeat: Replace TreeMap with List #4277

vpapavas opened this issue Jan 10, 2020 · 1 comment

Comments

@vpapavas
Copy link
Member

Is your feature request related to a problem? Please describe.
Currently heartbeats are stored in a concurrent hash map of tree maps. The alternative solution is to keep them in a list. We append to the list the new heartbeats. For processing them, we remove the heartbeats into a different data structure and then order them for processing.

Describe the solution you'd like
We should investigate which approach is more performant.

@vpapavas vpapavas added this to the 0.7.0 milestone Jan 10, 2020
@vpapavas vpapavas changed the title Heartbeat: Replace TreeMap with List Pull Queries: Heartbeat: Replace TreeMap with List Jan 13, 2020
@vinothchandar vinothchandar removed this from the 0.7.0 milestone Jan 21, 2020
@agavra
Copy link
Contributor

agavra commented Feb 3, 2021

I'm going to close this out as won't do - if we ever need to focus on performance improvements we should have that as an independent project, and the owner can be responsible of triaging and figuring out what is best.

@agavra agavra closed this as completed Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants