Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use public property names for Format properties #4444

Open
agavra opened this issue Feb 4, 2020 · 0 comments
Open

Use public property names for Format properties #4444

agavra opened this issue Feb 4, 2020 · 0 comments

Comments

@agavra
Copy link
Contributor

agavra commented Feb 4, 2020

See: #4437 (comment)

We want to be able to have pluggable schemas in the future, and formats often need configurations (e.g. VALUE_DELIMITER for the DELIMITED format) that are passed in the WITH clause. Today, there is a mapping from the public config name to what is used internally (e.g. VALUE_DELIMITER -> "delimiter"). When we support pluggable schemas, this mapping should be removed and we should just use the public name.

This may mean we need to change the way we pass the format specification in the WITH clause. For example, we could do something like:

WITH(value_format=FORMAT(name='DELIMITED', value_delimiter=','), key_format='KAFKA')
@vpapavas vpapavas added this to the 0.8.0 milestone Feb 12, 2020
@agavra agavra removed this from the 0.8.0 milestone Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants