Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Head truncation on incompatible commands in ksql-restore command #6305

Closed
stevenpyzhang opened this issue Sep 26, 2020 · 0 comments
Closed
Assignees
Labels
enhancement P0 Denotes must-have for a given milestone

Comments

@stevenpyzhang
Copy link
Member

Is your feature request related to a problem? Please describe.
As a follow up to #6286
We can extend it to head truncate certain commands.

Describe the solution you'd like
We can expose a parameter to head truncate commands from the command topic that are greater than some Command version number. This would help restore server functionality in the event of a rollback.

For the commands that are truncated, we'll need to search through them and check if there are any queries. For any queries, we'll need to take the application id/queryId and clean up internal topic and state stores.

Describe alternatives you've considered
Using special skip records in the command topic to skip certain commands.

@stevenpyzhang stevenpyzhang added enhancement P0 Denotes must-have for a given milestone labels Sep 26, 2020
@stevenpyzhang stevenpyzhang added this to the 0.14.0 milestone Sep 26, 2020
@stevenpyzhang stevenpyzhang self-assigned this Sep 26, 2020
@apurvam apurvam removed the P0 Denotes must-have for a given milestone label Oct 6, 2020
@vpapavas vpapavas added the P0 Denotes must-have for a given milestone label Oct 6, 2020
@vpapavas vpapavas removed this from the 0.14.0 milestone Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement P0 Denotes must-have for a given milestone
Projects
None yet
Development

No branches or pull requests

4 participants