Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "node" export condition #1014

Closed
timostamm opened this issue Feb 12, 2024 · 0 comments · Fixed by #1017
Closed

Remove "node" export condition #1014

timostamm opened this issue Feb 12, 2024 · 0 comments · Fixed by #1017
Labels
enhancement New feature or request

Comments

@timostamm
Copy link
Member

In #974, we made a change that removes a common failure point for the dual package hazard.

As a result, we can remove the "node" export condition from our package.json. The condition was intended to avoid the dual package hazard issue, but causes problems with some bundlers.

Similar issue for Protobuf-ES: bufbuild/protobuf-es#713
@timostamm timostamm added the enhancement New feature or request label Feb 12, 2024
@smaye81 smaye81 mentioned this issue Feb 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove node export condition connectrpc/connect-es
1 participant
@timostamm