Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace_pullspecs_everywhere does not update annotation names in relatedImages #56

Open
arewm opened this issue Sep 14, 2022 · 0 comments

Comments

@arewm
Copy link

arewm commented Sep 14, 2022

When annotation are included in the relatedImages, the name includes the tag:

return "{}-{}-annotation".format(image.repo, tag)

When calling replace_pullspecs_everywhere, however, the name is not updated if the tag changes. In order to keep these in sync, the related image name should be updated when an annotation is updated.

This can result in something like the following -- related images before replacement:

spec:
    relatedImages:
    - name: image-654321-annotation
      image: quay.io/operator/image@sha256:654321

Related images after replacement:

spec:
    relatedImages:
    - name: image-654321-annotation
      image: quay.io/operator/image@sha256:123456
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant