Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release notes for v1.7.10 #9426

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Conversation

ruiwen-zhao
Copy link
Member

@ruiwen-zhao ruiwen-zhao commented Nov 27, 2023

Welcome to the v1.7.10 release of containerd!

The tenth patch release for containerd 1.7 contains various fixes and updates.

Notable Updates

  • Enhance container image unpack client logs (#9379)
  • cri: fix using the pinned label to pin image (#9381)
  • fix: ImagePull should close http connection if there is no available data to read. (#9409)

See the changelog for complete list of changes

Please try out the release binaries and report any issues at
https://github.com/containerd/containerd/issues.

Contributors

  • Wei Fu
  • Iceber Gu
  • Austin Vazquez
  • Phil Estes
  • Samuel Karp
  • ruiwen-zhao

Changes

10 commits

Dependency Changes

This release has no dependency changes

Previous release can be found at v1.7.9

@ruiwen-zhao ruiwen-zhao marked this pull request as ready for review November 27, 2023 20:19
@ruiwen-zhao
Copy link
Member Author

cc @samuelkarp

@estesp
Copy link
Member

estesp commented Nov 27, 2023

Just FYI, CI is not triggering properly most likely due to an ongoing Github issue; from their status page: Update - Actions is experiencing degraded performance. We are continuing to investigate.

@dmcgowan
Copy link
Member

/test pull-containerd-node-e2e-1-7

@ruiwen-zhao
Copy link
Member Author

/test pull-containerd-node-e2e-1-7

Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

There are two Iceber Gus 😂

@AkihiroSuda
Copy link
Member

/test pull-containerd-node-e2e-1-7

@akhilerm
Copy link
Member

@ruiwen-zhao You can update the .mailmap file like this 1f865eb#diff-cfe707d774682f3bbb07d3be5119da9938f80153b7d2cc168c02de9b8595caccR48 to fix names appearing multiple times.

@ruiwen-zhao
Copy link
Member Author

ruiwen-zhao commented Nov 28, 2023

Test pull-containerd-node-e2e-1-7 keeps failing with

E2eNode Suite: [It] [sig-node] ResourceMetricsAPI [NodeFeature:ResourceMetrics] when querying /resource/metrics should report resource usage through the resource metrics api

{ failed [FAILED] Timed out after 60.006s.
Expected
    <metrics.KubeletMetrics | len:8>: 
...
to have key
    <string>: scrape_error
In [It] at: test/e2e_node/resource_metrics_test.go:121 @ 11/28/23 13:18:57.253
}

It is irrelevant to this PR, and the test has been failing for the same reason on other recent PRs, e.g. #9415 (comment)

Probably caused by the depreaction of scrape_error in this PR: https://github.com/kubernetes/kubernetes/pull/116897/files#diff-dd3c640c87eb316a6e5c6445d8914d43b7100d2366de31fa0f53f96de4294947R98. The metric is marked as deprecation in 1.29+.

Looking at the history of this test job, the test is passing on 1.29.0-Alpha (which is considered older than 1.29.0), and starts failing on v1.30.0-alpha. Fix needed on test side.

@samuelkarp
Copy link
Member

@ruiwen-zhao is that something that should be fixed on the Kubernetes e2e test side then?

@ruiwen-zhao
Copy link
Member Author

Created kubernetes/kubernetes#122095 to fix the test on k/k side.

@ruiwen-zhao
Copy link
Member Author

/test pull-containerd-node-e2e-1-7

@ruiwen-zhao
Copy link
Member Author

So pull-containerd-node-e2e-1-7 is fixed and all tests passing now. I also fixed the double names.

Can I get some new approvals?

@dmcgowan dmcgowan merged commit 4e1fe74 into containerd:release/1.7 Nov 29, 2023
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants