Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues and requirements for next test-tooling updates #3448

Open
12 of 22 tasks
apostasie opened this issue Sep 21, 2024 · 0 comments
Open
12 of 22 tasks

Issues and requirements for next test-tooling updates #3448

apostasie opened this issue Sep 21, 2024 · 0 comments

Comments

@apostasie
Copy link
Contributor

apostasie commented Sep 21, 2024

As we rewrite tests, missing pieces and bugs in the tooling will appear.
This is to collect them:

  • mode private propagation is problematic, as each subtest is in its own isolated namespace - ideally, the subtest would by default be in the parent namespace
  • async commands are clunky to use right now - implemented foreground and background, but it would be better to just have a setting on the command that would somehow switch from RunCmd to Start+WaitCmd - design TBD
  • testutil.RequiresBuild and many others are missing: review them all
  • having to use test.Case at the root of the test is not elegant (especially since it requires a redundant/useless description. Maybe ‘Setup’ could return a prepolulated test.Case instead
  • use of data.Identifier in subtests hoping to get the parent testid is error prone - rethink Identifier() and maybe use data.set(mainId) or something in the line
  • test.Group being parallel with no way to change it is confusing/error prone. Questioning the value of test.Group entirely.
  • nerdtest.Command is annoyingly convoluted - rethink the use of Target and maybe remove it along with custom Run/Clone
  • in line with above, some functions cannot be hidden with t.Helper - rethink that
  • identifier hashing (sha1) method is unsatisfying - should go back to something readable
  • missing something like .AddCleanup() when a routine inside Setup does want to add additional cleaning
  • requirements are now called twice, because of the issue with Private

Test suites to rewrite:

  • started: builder
  • completion
  • TODO: compose
  • started: container
  • in progress: image
  • TODO: ipfs
  • in progress: login
  • network
  • system
  • volume
  • main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant