Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support .containerignore #3595

Open
benatkin opened this issue Oct 23, 2024 · 1 comment
Open

Support .containerignore #3595

benatkin opened this issue Oct 23, 2024 · 1 comment

Comments

@benatkin
Copy link

What is the problem you're trying to solve

Confusion about the difference between Docker and OCI images, consistency with Podman and Containerfile

OCI Images have been a thing for a long time, but people think it's a Docker thing, when it is not only a Docker thing. Besides nerdctl, OCI images are run in MicroVMs.

Describe the solution you'd like

When calling BuildKit detect if .dockerignore doesn't exist but .containerignore exists, copy or rename .containerignore to .dockerignore and delete or rename it back after it completes or fails.

Consider warning if there is a mismatch between Dockerfile / .dockerignore and Containerfile / .containerignore.

Additional context

BuildKit doesn't support .containerignore - the issue was closed with "No interest." moby/buildkit#3108

@benatkin benatkin changed the title Support containerignore Support .containerignore Oct 23, 2024
@apostasie
Copy link
Contributor

Describe the solution you'd like

When calling BuildKit detect if .dockerignore doesn't exist but .containerignore exists, copy or rename .containerignore to .dockerignore and delete or rename it back after it completes or fails.

Unfortunately that would wreak concurrent builds.

Unless buildkit implements it, I am not sure there is a good solution here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants