From 786bd0eaf00503e437dbcc78bda2c7a9706813e1 Mon Sep 17 00:00:00 2001 From: Tim Zhang Date: Mon, 23 Sep 2024 17:58:34 +0800 Subject: [PATCH 1/2] Fix clippy warnings for rust 1.77.0 Prepare locking rust vertion to rust 1.77.0. Signed-off-by: Tim Zhang --- build.rs | 2 +- src/asynchronous/client.rs | 14 -------------- 2 files changed, 1 insertion(+), 15 deletions(-) diff --git a/build.rs b/build.rs index 78dd934..6ac144f 100644 --- a/build.rs +++ b/build.rs @@ -10,7 +10,7 @@ fn main() { #[allow(clippy::needless_borrow)] protobuf_codegen_pure::Codegen::new() .out_dir(out_dir) - .inputs(&["src/ttrpc.proto"]) + .inputs(["src/ttrpc.proto"]) .include("src") .run() .expect("Codegen failed."); diff --git a/src/asynchronous/client.rs b/src/asynchronous/client.rs index 73ca310..c001b54 100644 --- a/src/asynchronous/client.rs +++ b/src/asynchronous/client.rs @@ -3,7 +3,6 @@ // SPDX-License-Identifier: Apache-2.0 // -use nix::unistd::close; use protobuf::{CodedInputStream, Message}; use std::collections::HashMap; use std::os::unix::io::RawFd; @@ -158,19 +157,6 @@ impl Client { } } -struct ClientClose { - fd: RawFd, - close_fd: RawFd, -} - -impl Drop for ClientClose { - fn drop(&mut self) { - close(self.close_fd).unwrap(); - close(self.fd).unwrap(); - trace!("All client is droped"); - } -} - // Spwan a task and transfer the response fn spawn_trans_resp( req_map: Arc>>, From 4db7788dee411f0a1e2ede309da76bf56c2b84a4 Mon Sep 17 00:00:00 2001 From: Tim Zhang Date: Mon, 23 Sep 2024 17:58:58 +0800 Subject: [PATCH 2/2] Lock rust vertion to 1.77.0 for CI stability If don't lock it, new lint errors occur follow new rust versions. Signed-off-by: Tim Zhang --- rust-toolchain.toml | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 rust-toolchain.toml diff --git a/rust-toolchain.toml b/rust-toolchain.toml new file mode 100644 index 0000000..c058c59 --- /dev/null +++ b/rust-toolchain.toml @@ -0,0 +1,4 @@ +[toolchain] +channel="1.77.0" +profile="default" +components=["rustfmt", "clippy"]