rootless: tagging of built image doesn't seem to work

[dustymabe]

/kind bug

Description

I run podman build . -t sync2jira I expect the resulting image to get the tag. It doesn't. For example I saw:

STEP 25: FROM a2ca749662b4fbe156cef473e586072f3c56cfd94d42c74ae968b3b5441911f0
STEP 26: CMD ["/usr/local/bin/sync2jira"]
--> cf2c605849dc1442f2783e9337d4bcb9578ed1319fa05c52242e089ed2226095
STEP 27: COMMIT
[dustymabe@media sync2jira (dusty *%)]$ podman images
REPOSITORY                                 TAG      IMAGE ID       CREATED             SIZE
<none>                                     <none>   cf2c605849dc   52 seconds ago      924 MB
<none>                                     <none>   8c3a9bb5bf74   About an hour ago   439 MB
localhost/sync2jira                        latest   0ed4a4f539e2   About an hour ago   439 MB

Steps to reproduce the issue:

1. podman build . -t sync2jira

2. podman images

Output of podman version:

[dustymabe@media sync2jira (dusty *%)]$ rpm -q podman
podman-1.1.2-1.git0ad9b6b.fc29.x86_64
[dustymabe@media sync2jira (dusty *%)]$ podman version
Version:            1.1.2
RemoteAPI Version:  1
Go Version:         go1.11.5
Git Commit:         a95a49d3038462d033f84ac314ec8a3064a99cff
Built:              Tue Mar  5 13:10:31 2019
OS/Arch:            linux/amd64

Output of podman info --debug:

[dustymabe@media sync2jira (dusty *%)]$ podman info --debug
debug:
  compiler: gc
  git commit: a95a49d3038462d033f84ac314ec8a3064a99cff
  go version: go1.11.5
  podman version: 1.1.2
host:
  BuildahVersion: 1.7.1
  Conmon:
    package: podman-1.1.2-1.git0ad9b6b.fc29.x86_64
    path: /usr/libexec/podman/conmon
    version: 'conmon version 1.12.0-dev, commit: a95a49d3038462d033f84ac314ec8a3064a99cff'
  Distribution:
    distribution: fedora
    version: "29"
  MemFree: 2131562496
  MemTotal: 20999905280
  OCIRuntime:
    package: runc-1.0.0-68.dev.git6635b4f.fc29.x86_64
    path: /usr/bin/runc
    version: |-
      runc version 1.0.0-rc6+dev
      commit: ef9132178ccc3d2775d4fb51f1e431f30cac1398-dirty
      spec: 1.0.1-dev
  SwapFree: 4294963200
  SwapTotal: 4294963200
  arch: amd64
  cpus: 8
  hostname: media
  kernel: 4.20.14-200.fc29.x86_64
  os: linux
  rootless: true
  uptime: 8h 19m 18.88s (Approximately 0.33 days)
insecure registries:
  registries: []
registries:
  registries:
  - docker.io
  - registry.fedoraproject.org
  - quay.io
  - registry.access.redhat.com
  - registry.centos.org
store:
  ConfigFile: /home/dustymabe/.config/containers/storage.conf
  ContainerStore:
    number: 18
  GraphDriverName: overlay
  GraphOptions:
  - overlay.mount_program=/usr/bin/fuse-overlayfs
  GraphRoot: /var/b/dustymabe-config-containers/storage
  GraphStatus:
    Backing Filesystem: extfs
    Native Overlay Diff: "false"
    Supports d_type: "true"
    Using metacopy: "false"
  ImageStore:
    number: 32
  RunRoot: /run/user/1001
  VolumePath: /home/dustymabe/.local/share/containers/storage/volumes

[rhatdan]

Am I missing something?

localhost/sync2jira latest 0ed4a4f539e2 About an hour ago 439 MB
Looks like the tag?

[dustymabe]

Right. I had previously run podman build . and podman image tag 0ed4a4f539e2 an hour before. This was a subsequent run of podman build . -t sync2jira that occured 52 seconds ago and created cf2c605849dc. It's subtle, but you can see it in the output I pasted.

[mheon]

@dustymabe If you remove the tagged image, is it tagged again?

I wonder if we're refusing to tag because the image in question already exists

[dustymabe]

@dustymabe If you remove the tagged image, is it tagged again?

Nope.

[dustymabe@media sync2jira (dusty *%)]$ podman images                                                                                                                                                                                                                                                                                                                    
REPOSITORY                                 TAG      IMAGE ID       CREATED        SIZE                                                                                                                                                                                                                                                                                    
<none>                                     <none>   8c3a9bb5bf74   18 hours ago   439 MB                                                                                                                                                                                                                                                                                 
docker.io/library/fedora                   latest   d09302f77cfc   2 days ago     283 MB                                                                                                                                                                                                                                                                                 
registry.fedoraproject.org/fedora          29       69c5db8b64a7   2 months ago   283 MB                                                                                                                                                                                                                                                                                 
registry.centos.org/centos                 7        719ea9c10b97   2 months ago   210 MB                                                                                                                                                                                                                                                                                 
quay.io/factory2/sync2jira-jenkins-slave   latest   55ea5c07ce83   6 months ago   1.33 GB                                                                                                                                                                                                                                                                                
[dustymabe@media sync2jira (dusty *%)]$                                                                                                                                                                                                                                                                                                                                  
[dustymabe@media sync2jira (dusty *%)]$ podman build . -t sync2jira                                                                                                                                                                                                                                                                                                      
STEP 1: FROM fedora:latest
.
.
.

STEP 26: CMD ["/usr/local/bin/sync2jira"]
--> d5a8f69516dbcf08836e99a0112656ec2ca811965e4db167fa47c76e88c09af2
STEP 27: COMMIT
[dustymabe@media sync2jira (dusty *%)]$ podman images
REPOSITORY                                 TAG      IMAGE ID       CREATED          SIZE
<none>                                     <none>   d5a8f69516db   17 seconds ago   924 MB
<none>                                     <none>   8c3a9bb5bf74   18 hours ago     439 MB
docker.io/library/fedora                   latest   d09302f77cfc   2 days ago       283 MB
registry.fedoraproject.org/fedora          29       69c5db8b64a7   2 months ago     283 MB
registry.centos.org/centos                 7        719ea9c10b97   2 months ago     210 MB
quay.io/factory2/sync2jira-jenkins-slave   latest   55ea5c07ce83   6 months ago     1.33 GB

I wonder if we're refusing to tag because the image in question already exists

If that were the case it would still be a bug, right?

[giuseppe]

I added the rootless label too early, I can reproduce with root as well

[mheon]

@dustymabe Would definitely still have been a bug, though a different kind

[giuseppe]

it is cobra messing up I think.

the order matters: podman build . -t sync2jira fails while podman build -t sync2jira . works

[mheon]

Is Build missing SetInterspersed?

[giuseppe]

yes, I am preparing a PR right now

[giuseppe]

PR here: #2646