-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility: Add filters for listing networks #7462
Comments
The problem is that podman handles networking differently from docker. The podman backend only supports |
Considering that we already need a system service for docker compatibility, how is it difficult to maintain a list of networks to implement this feature? What is blocking this api exactly? |
@mheon stated that he is looking to improve this in the future #7080 (comment) @minioin Do you know what filter k3d is using? I think we can at least implement the name filter for now. |
@minioin Time is the only thing blocking us. Getting community to help build it is always helpful. |
@Luap99 , in k3d we're only filtering by name: https://github.com/rancher/k3d/blob/main/pkg/runtimes/docker/network.go#L47-L54 // (1) configure list filters
args := filters.NewArgs()
args.Add("name", name)
// (2) get filtered list of networks
networkList, err := docker.NetworkList(ctx, types.NetworkListOptions{
Filters: args,
}) |
@iwilltry42 @minioin @Luap99 Can we close this issue now since your PR has been merged? |
I'm going to go ahead and close this. We're not 100% there yet, but we can open separate, more specific issues for any remaining missing filters. |
I tried to run k3d with podman system service but k3d returned error with
filters for listing networks is not implemented
. As I looked at docker api, it lists filters as an option.This features is one of the first thing I encountered while running k3d under podman .
The text was updated successfully, but these errors were encountered: