Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for feature subcommand #815

Open
utam0k opened this issue Apr 3, 2022 · 10 comments · May be fixed by #2837
Open

Support for feature subcommand #815

utam0k opened this issue Apr 3, 2022 · 10 comments · May be fixed by #2837
Assignees
Labels
good first issue Good for newcomers

Comments

@utam0k
Copy link
Member

utam0k commented Apr 3, 2022

Initially, we would like to respond statically. It means hard coding.
opencontainers/runtime-spec#1130

@utam0k utam0k added the good first issue Good for newcomers label Apr 3, 2022
@chinzhiweiblank
Copy link

chinzhiweiblank commented Apr 25, 2022

Hi! I would like to try this. I am to implement youki features which returns the result in a parseable JSON format like runc. Just that the fields are hard-coded for now. The fields are found here. How do I find out the values for each field?

Is that correct?

@utam0k
Copy link
Member Author

utam0k commented Apr 28, 2022

@chinzhiweiblank We need to consider how to dynamically search for fields. I think hard coding is fine for once. If you're up for the challenge, I'll assign it. What do you think?

@chinzhiweiblank
Copy link

No problem. I can take it. @utam0k

@chinzhiweiblank
Copy link

Hey @utam0k, currently I have a struct with these fields. How do I find out what I should fill in for the fields?

    let feature_config = FeatureConfig {
        oci_version_min: "", // TODO
        oci_version_max: "", // TODO
        hooks: vec!["prestart", "createRuntime", "createContainer", "startContainer", "poststart", "poststop"], // TODO
        mount_options: vec![], // TODO
        linux: Linux {
            namespaces: vec![], // TODO
            capabilities: vec![], // TODO
            cgroup: Cgroup {
                v1: true,
                v2: false,
                systemd: true,
                systemduser: true,
            },
            seccomp: Seccomp {
                enabled: true,
                actions: vec![], // TODO
                operators: vec![], // TODO
                archs: vec![], // TODO
            },
            apparmor: Apparmor {
                enabled: true,
            },
            selinux: Selinux {
                enabled: true,
            },
        },

@utam0k
Copy link
Member Author

utam0k commented May 20, 2022

@chinzhiweiblank Why don't you try using youki with these features you want to know?

@utam0k
Copy link
Member Author

utam0k commented Sep 20, 2023

@chinzhiweiblank Is this going on now? Let us know if there is anything we can do to help.

@DarrellTang
Copy link

if @chinzhiweiblank isn't able to get to this, I'd like to try, if possible. I'm pretty new to rust and a devops engineer by day, so I would probably need some handholding though.

@utam0k
Copy link
Member Author

utam0k commented Sep 23, 2023

@DarrellTang Sure. Let's give it a try!

@musaprg musaprg linked a pull request Jun 29, 2024 that will close this issue
2 tasks
@musaprg
Copy link
Contributor

musaprg commented Jul 7, 2024

@utam0k Hi, could you assign me to this issue? I'm going to start taking over the PR submitted by @DarrellTang.

@utam0k utam0k assigned musaprg and unassigned DarrellTang Jul 22, 2024
@utam0k
Copy link
Member Author

utam0k commented Jul 22, 2024

@utam0k Hi, could you assign me to this issue? I'm going to start taking over the PR submitted by @DarrellTang.

Sure. Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants