Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix prometheus metrics example #1157

Merged
merged 1 commit into from
Feb 21, 2017
Merged

Fix prometheus metrics example #1157

merged 1 commit into from
Feb 21, 2017

Conversation

solidnerd
Copy link
Contributor

Traefik won’t start correctly if heterogeneous numbers in a toml array. This commit makes all numbers homogene.

Error Message Output:

traefik_1   | 2017/02/13 10:39:19 Error reading TOML config file /var/traefik/traefik.toml : Near line 96 (last key parsed 'web.metrics.prometheus.Buckets'): Array contains values of type 'Float' and 'Integer', but arrays must be homogeneous.

Signed-off-by: solidnerd [email protected]

vdemeester
vdemeester approved these changes Feb 13, 2017
View reviewed changes
Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

SantoDE
SantoDE approved these changes Feb 20, 2017
View reviewed changes
Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👼

@solidnerd
Fix prometheus metrics example
60b3f74 
Traefik won’t start correctly if heterogeneous numbers in a toml array.  This commit makes all numbers homogene.

Signed-off-by: solidnerd <[email protected]>
@SantoDE SantoDE force-pushed the fix-prometheus-in-traefik-example-toml branch from 6a64837 to 60b3f74 Compare February 21, 2017 06:55
@vdemeester vdemeester merged commit 8c82468 into traefik:master Feb 21, 2017
@ldez ldez added the kind/enhancement a new or improved feature. label Apr 29, 2017
@ldez ldez added this to the 1.3 milestone May 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SantoDE SantoDE SantoDE approved these changes

@vdemeester vdemeester vdemeester approved these changes

Assignees
No one assigned
Labels
area/documentation area/middleware/metrics kind/enhancement a new or improved feature.
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
4 participants
@solidnerd @vdemeester @SantoDE @ldez