-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade k8s.io/client-go to version 2 #1178
Conversation
ping @containous/traefik |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@errm WOW
This will be completely impossible to maintain in the future. Is it the best way to do this??? We should at least add comments before and after those manual k8s deps. |
@emilevauge If you are worried about dependencies becoming obsolete/unused in the future but never make their way out of the I know: Throwing a plugin at this problem is just another symptom for how miserable things are in the Go dependency management space. |
FYI Glide install procedure will be updated -> kubernetes/client-go#127 so
is enouth in glide.yml |
I am taking another look at this... @ekozan I have updated glide.yaml but there are now some issues with cyclical imports... |
cbddb59
to
ff1aae5
Compare
@errm Should I close this one, or do you want to work on this ? |
affef25
to
f84af19
Compare
This should be good to go now ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @errm
LGTM
No description provided.