Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Docker test provider instantiation into t.Run body. #1489

Merged
merged 3 commits into from
Apr 25, 2017
Merged

Move Docker test provider instantiation into t.Run body. #1489

merged 3 commits into from
Apr 25, 2017

Conversation

timoreimann
Copy link
Contributor

Piggyback change to pass TESTDIRS env var through to the Docker build container to run the test-unit Makefile target on limited packages/files.

Fixes #1443.

@timoreimann timoreimann force-pushed the docker-move-test-providers-into-run-body branch from 3387144 to a0a945e Compare April 24, 2017 16:15
@timoreimann
Copy link
Contributor Author

NB: The latest commit is just to show that things work fine on Travis. It will be removed prior to merging.

@timoreimann
Copy link
Contributor Author

@containous/traefik PTAL.

@timoreimann timoreimann added this to the 1.3 milestone Apr 24, 2017
vdemeester
vdemeester approved these changes Apr 24, 2017
View reviewed changes
Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸
I think we should remove the last commit (and remove travis_retry 😅)

@timoreimann timoreimann force-pushed the docker-move-test-providers-into-run-body branch from a0a945e to 8f64483 Compare April 24, 2017 20:15
@timoreimann
Copy link
Contributor Author

@vdemeester retry removed, last commit dropped. :-)

@timoreimann
Copy link
Contributor Author

@emilevauge LGTY?

@ldez ldez added kind/bug/fix a bug fix and removed bug labels Apr 25, 2017
@timoreimann timoreimann mentioned this pull request Apr 25, 2017
Closed
emilevauge
emilevauge approved these changes Apr 25, 2017
View reviewed changes
Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @timoreimann
LGTM

@vdemeester
Copy link
Contributor

@timoreimann needs a rebase 👼

@timoreimann timoreimann force-pushed the docker-move-test-providers-into-run-body branch from 8f64483 to 25abf8b Compare April 25, 2017 12:56
@timoreimann timoreimann merged commit 49a9aeb into master Apr 25, 2017
@timoreimann timoreimann deleted the docker-move-test-providers-into-run-body branch April 25, 2017 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@emilevauge emilevauge emilevauge approved these changes

Assignees
No one assigned
Labels
area/infrastructure area/provider/docker kind/bug/fix a bug fix
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
4 participants
@timoreimann @vdemeester @emilevauge @ldez