Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documented ProvidersThrottleDuration value is invalid #741

Closed
jdeathe opened this issue Oct 17, 2016 · 5 comments
Closed

Documented ProvidersThrottleDuration value is invalid #741

jdeathe opened this issue Oct 17, 2016 · 5 comments

Comments

@jdeathe
Copy link

jdeathe commented Oct 17, 2016

The value of ProvidersThrottleDuration needs to be defined as an integer. Using the documented example results in the following error:

Error reading TOML config file /path/to/traefik.toml : toml: cannot load TOML value of type string into a Go integer

Ref:

i.e ProvidersThrottleDuration = "5s" should be ProvidersThrottleDuration = 5

Suggest also adding the unit suffix s to the debug logs for clarity:

@emilevauge
Copy link
Member

Fixed by #760

@bbinet
Copy link
Contributor

bbinet commented May 10, 2017

I've just faced this same issue again with v1.2.3.
It seems this doc issue has been reintroduced:
https://github.com/containous/traefik/search?q=ProvidersThrottleDuration&type=Code&utf8=%E2%9C%93

@bbinet
Copy link
Contributor

bbinet commented May 10, 2017

It seems it has been reintroduced on purpose with commit 056fe9a but my traefik won't start if I set ProvidersThrottleDuration = "2s" in the toml config.
It then fails with message: Error reading TOML config file /traefik.toml : toml: cannot load TOML value of type string into a Go integer

@timoreimann
Copy link
Contributor

timoreimann commented May 10, 2017

@bbinet unfortunately, the docs only reflect the latest released version, including release candidates (we yet have to change to versioned docs, see also #1279). In #1350, we added an improvement to support specifying all time units in either a unit-less format (defaulting to seconds) or with a unit suffix understood by Go's time.ParseDuration. Once you switch to Traefik 1.3 (or a release candidate thereof), you get to pick what you prefer.

@bbinet
Copy link
Contributor

bbinet commented May 10, 2017

Ok, thanks.

@traefik traefik locked and limited conversation to collaborators Sep 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants