Import order as goimports does #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdemeester
force-pushed
the
import-order
branch
from
b2745b8
to
6e94992
Compare
dtomcej
approved these changes
Dec 30, 2016
Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
force-pushed
the
import-order
branch
from
6e94992
to
b7a0b63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-order imports on all files according to
goimports, i.e. built-in first, then the other ones, in order.It's a little bit OCD, but also if we decide to use this as code style, it's like
gofmt, something else where conflicts should happen less./cc @containous/traefik
🐸
Signed-off-by: Vincent Demeester [email protected]