-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FreeBSD & OpenBSD to crossbinary #1078
Conversation
I think the test fail might just be caused by vendoring issues. The integration tests have there own and separate vendor folder due to some incompatibilities between different versions of pflag. Could you try
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐡
/me waiting for @emilevauge opinion
Doing I'm currently doing this in a jail, so I'm not sure what hoops I'd need to jump through to get Docker working inside it, I've only had mixed success with Docker on FreeBSD on bare or vm servers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @geoffgarside
Even if travis builds will be slower than today :'(
Ouch that is a long build time :'( |
Closes #923
Binaries are successfully built via the
script/crossbinary
.While I've not got an OpenBSD server or VM to hand, I've tested the
go
+glide
method on a FreeBSD server, ago build
completes successfully however ago test $(glide novendor)
has a build failure ingithub.com/containous/traefik/integration
as followsbut I'm not really familiar enough with Docker to know whether these would be expected on FreeBSD or if they are a current issue for Linux as well.
The other packages (those with tests) all pass.