Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FreeBSD & OpenBSD to crossbinary #1078

Merged
merged 2 commits into from
Feb 3, 2017
Merged

Add FreeBSD & OpenBSD to crossbinary #1078

merged 2 commits into from
Feb 3, 2017

Conversation

geoffgarside
Copy link
Contributor

Closes #923

Binaries are successfully built via the script/crossbinary.

While I've not got an OpenBSD server or VM to hand, I've tested the go + glide method on a FreeBSD server, a go build completes successfully however a go test $(glide novendor) has a build failure in github.com/containous/traefik/integration as follows

# go test github.com/containous/traefik/integration
# github.com/containous/traefik/vendor/github.com/docker/docker/pkg/mount
cc: warning: argument unused during compilation: '-gno-record-gcc-switches'
# github.com/containous/traefik/vendor/github.com/docker/docker/pkg/mount
cc: warning: argument unused during compilation: '-pthread'
cc: warning: argument unused during compilation: '-gno-record-gcc-switches'
# github.com/containous/traefik/vendor/github.com/docker/docker/runconfig/opts
vendor/github.com/docker/docker/runconfig/opts/parse.go:530: flags.Changed undefined (type *pflag.FlagSet has no field or method Changed)
FAIL	github.com/containous/traefik/integration [build failed]

but I'm not really familiar enough with Docker to know whether these would be expected on FreeBSD or if they are a current issue for Linux as well.

The other packages (those with tests) all pass.

@errm
Copy link
Contributor

errm commented Jan 28, 2017

I think the test fail might just be caused by vendoring issues. The integration tests have there own and separate vendor folder due to some incompatibilities between different versions of pflag.

Could you try

cd integration && glide install
cd ..
script/test-integration
``

Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐡
/me waiting for @emilevauge opinion

@geoffgarside
Copy link
Contributor Author

Doing glide install in the integration folder gets things to build a bit further, but they seem to assume the presence of a Docker service, the script/test-integration also assumes Docker is present (also that bash is at /bin/bash rather than /usr/local/bin/bash)

I'm currently doing this in a jail, so I'm not sure what hoops I'd need to jump through to get Docker working inside it, I've only had mixed success with Docker on FreeBSD on bare or vm servers.

Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @geoffgarside
Even if travis builds will be slower than today :'(

@geoffgarside
Copy link
Contributor Author

Ouch that is a long build time :'(

@vdemeester vdemeester merged commit 29059b7 into traefik:master Feb 3, 2017
@geoffgarside geoffgarside deleted the release-build-bsd branch February 5, 2017 10:15
@ldez ldez added this to the 1.2 milestone May 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants