Fix docker version specifier #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoreimann
force-pushed
the
fix-docker-version-specifier
branch
from
189a413
to
910a33a
Compare
- The download URL[1] does not contain a leading 'v'. - The major version is 1. [1] https://github.com/docker/docker/releases/tag/v1.10.3
- `-f` (`--fail`) turns HTTP error response codes into a non-zero exit code, making curl fail early and properly. While the documentation mentions that there is supposed to be no output, we do see an error message. - `-S` (`--show-error`) is only meaningful when used together with `-s` (`--silent`). We do not want to go silent but see the progress bar though.
|
@emilevauge please take a look. |
|
if desired, I can insert a commit that shows the problem followed by the fix. |
|
Indeed, I was also preparing a PR to fix that ;) thanks! |
emilevauge
referenced
this pull request
Feb 2, 2017
* Fix travis script Signed-off-by: Emile Vauge <[email protected]> * how do i pronounce this damn project Signed-off-by: Emile Vauge <[email protected]> * Remove unstable Docker 1.13 tests Signed-off-by: Emile Vauge <[email protected]>
vdemeester
approved these changes
Feb 3, 2017
jangie
pushed a commit
to jangie/traefik
that referenced
this pull request
Feb 23, 2017
* Fix Docker version specifier. - The download URL[1] does not contain a leading 'v'. - The major version is 1. [1] https://github.com/docker/docker/releases/tag/v1.10.3 * Drop -S and and -f in build.Dockerfile curl commands. - `-f` (`--fail`) turns HTTP error response codes into a non-zero exit code, making curl fail early and properly. While the documentation mentions that there is supposed to be no output, we do see an error message. - `-S` (`--show-error`) is only meaningful when used together with `-s` (`--silent`). We do not want to go silent but see the progress bar though.
ldez
added
status/3-needs-merge
area/provider/docker
and removed
status/2-needs-review
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit from PR #1067 introduced a wrong Docker version specifier: The major version is 1 and does not come with a leading
vcharacter. The PR corrects both.To my surprise, the Docker build on Travis CI did not invalidate the cache when the originating PR ran. As far as I understand the documentation, this should have been the case.The problem wasn't caught during the Travis CI run since we set theDOCKER_VERSIONenvironment variable in the Travis configuration file and pass it through as the build argument, thereby never invalidating the corresponding Docker cache layer since ARGs are invalidated only when their content changes. Running any Docker-requiring Make target locally, however, surfaces the issue. I'm not exactly sure how to detect such problems in the future.Additionally, it wasn't super easy to spot the problem due to the chosen curl parameters. Hence, I piggybacked the following changes:
-f(--fail): It turns HTTP error response codes into non-zero exit codes, making curl fail early and properly. While the documentation mentions that there is supposed to be no output, we do see an error message. (I got a pretty clear curl: (22) The requested URL returned error: 403 Forbidden.)-S(--show-error): It is only meaningful when used together with-s(--silent). We do not want to go silent but see the progress bar though.