Fix docker issues with global and dead tasks #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vdemeester we could get this one in v1.2 right ? |
|
@emilevauge I think so |
emilevauge
force-pushed
the
bugfix-docker
branch
2 times, most recently
from
b84f030
to
69f939d
Compare
|
Rebased on branch v1.2. |
|
@emilevauge I'll look into doing that asap. I've also been using this branch on a local swarm cluster for about a week now and didn't run into any issue yet with both replicated and global services. |
errm
approved these changes
Feb 21, 2017
emilevauge
approved these changes
Feb 22, 2017
emilevauge
force-pushed
the
bugfix-docker
branch
from
3be508c
to
d342ae6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple small issues with Docker fixed in this PR:
docker service create --mode global) do not have aSlotID in the task list, so each entry will end up having the same name in the backend configuration making the docker provider crash. This fallbacks to using theTaskIDinstead if the service is global.desired-state: runningfilter to the task list query so that we only use alive tasks as backends.Fixes #1138