Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature web root path #1233

Merged
merged 1 commit into from
Mar 24, 2017
Merged

Feature web root path #1233

merged 1 commit into from
Mar 24, 2017

Conversation

tcoupin
Copy link
Contributor

@tcoupin tcoupin commented Mar 3, 2017

Allow to set the root path for webui and API

Adding 'path' parameter for web provider.
Adding redirect from '/' to '/path'

Path can be :

  • ''
  • '/'
  • '/path'
  • '/path/'

@SantoDE SantoDE self-requested a review March 24, 2017 08:50
SantoDE
SantoDE approved these changes Mar 24, 2017
View reviewed changes
Copy link
Collaborator

@SantoDE SantoDE left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tcoupin ,

thanks for your PR! :)

Could you please squash your commits? LGTM to me once the build finished green ;)

@SantoDE SantoDE added this to the 1.3 milestone Mar 24, 2017
emilevauge
emilevauge approved these changes Mar 24, 2017
View reviewed changes
Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks @tcoupin :)

@SantoDE
Copy link
Collaborator

SantoDE commented Mar 24, 2017

Thanks @tcoupin,

after travis is green I'll merge that :)

@SantoDE SantoDE merged commit 240b2be into traefik:master Mar 24, 2017
@ldez ldez added the kind/enhancement a new or improved feature. label Apr 29, 2017
@ldez ldez mentioned this pull request May 26, 2017
Closed
@gozer gozer mentioned this pull request Aug 28, 2017
Closed
@tcoupin tcoupin mentioned this pull request Jan 8, 2018
Merged
@juliens juliens mentioned this pull request Jan 10, 2018
Merged
@tcoupin tcoupin deleted the feature-web-pathprefix branch October 6, 2018 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilevauge emilevauge emilevauge approved these changes

@SantoDE SantoDE SantoDE approved these changes

Assignees
No one assigned
Labels
area/api area/webui kind/enhancement a new or improved feature.
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
4 participants
@tcoupin @SantoDE @emilevauge @ldez