make docs more clear about how to work with the current api #1337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we update the sample file too? |
timoreimann
approved these changes
Mar 27, 2017
timoreimann
suggested changes
Mar 27, 2017
There was a problem hiding this comment.
Changing status just so we don't accidentally merge until @SantoDE has amended the sample file too.
|
Ping @SantoDE ;) |
|
@SantoDE Do you have time to update the sample file? |
SantoDE
force-pushed
the
fix/rancher_docs
branch
2 times, most recently
from
e019a90
to
48a43c6
Compare
|
Hey @timoreimann & @ldez , done ;-) |
|
@SantoDE can you change the PR from v1.2 to master |
SantoDE
force-pushed
the
fix/rancher_docs
branch
from
48a43c6
to
9a0907c
Compare
|
@ldez done :) |
ldez
approved these changes
Apr 24, 2017
|
Update of |
SantoDE
force-pushed
the
fix/rancher_docs
branch
from
9a0907c
to
14d5963
Compare
|
Ah, yeah! :D Sorry. we have to many examples 👼 done @timoreimann |
emilevauge
force-pushed
the
fix/rancher_docs
branch
from
14d5963
to
c1f4a13
Compare
timoreimann
previously requested changes
Apr 25, 2017
| @@ -996,43 +996,43 @@ | |||
| # | |||
| # Optional | |||
| # | |||
| #[rancher] | |||
There was a problem hiding this comment.
I think we want to leave all ranger configuration parameters commented out, as with the other providers in the sample file.
AFAIU, the idea is that users copy the file and uncomment just what they need.
See also #1455.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @containous/traefik :)