Add global health check interval parameter. #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoreimann
added
kind/enhancement
|
The PR currently builds on #1320. Will be rebased once upstream gets merged. |
timoreimann
force-pushed
the
add-global-option-for-healthcheck-interval
branch
2 times, most recently
from
3c0fa6f
to
757b0c2
Compare
timoreimann
changed the title
|
This isn't working yet because |
timoreimann
changed the title
timoreimann
force-pushed
the
configure-healthcheck-via-marathon-label
branch
from
73f02f6
to
031c82c
Compare
timoreimann
force-pushed
the
add-global-option-for-healthcheck-interval
branch
from
757b0c2
to
70d819e
Compare
timoreimann
force-pushed
the
configure-healthcheck-via-marathon-label
branch
from
031c82c
to
2c073ad
Compare
timoreimann
force-pushed
the
add-global-option-for-healthcheck-interval
branch
2 times, most recently
from
c42759f
to
d273fa0
Compare
timoreimann
force-pushed
the
configure-healthcheck-via-marathon-label
branch
3 times, most recently
from
9c62808
to
6412620
Compare
timoreimann
force-pushed
the
add-global-option-for-healthcheck-interval
branch
from
d273fa0
to
34711c9
Compare
timoreimann
force-pushed
the
configure-healthcheck-via-marathon-label
branch
from
6412620
to
501c916
Compare
timoreimann
force-pushed
the
add-global-option-for-healthcheck-interval
branch
from
34711c9
to
8a27d8e
Compare
timoreimann
force-pushed
the
configure-healthcheck-via-marathon-label
branch
from
501c916
to
4d7f3d5
Compare
timoreimann
force-pushed
the
add-global-option-for-healthcheck-interval
branch
from
8a27d8e
to
620d4db
Compare
timoreimann
force-pushed
the
configure-healthcheck-via-marathon-label
branch
from
4d7f3d5
to
8a99789
Compare
timoreimann
force-pushed
the
add-global-option-for-healthcheck-interval
branch
from
620d4db
to
b2cbb8f
Compare
|
Everything's working as expected for quite a while now. |
ldez
approved these changes
Apr 25, 2017
timoreimann
force-pushed
the
configure-healthcheck-via-marathon-label
branch
2 times, most recently
from
9b15cf7
to
c2f8bcc
Compare
timoreimann
force-pushed
the
configure-healthcheck-via-marathon-label
branch
4 times, most recently
from
06d365d
to
db3e461
Compare
emilevauge
approved these changes
Apr 28, 2017
|
@timoreimann Need rebase 😉 |
timoreimann
force-pushed
the
configure-healthcheck-via-marathon-label
branch
3 times, most recently
from
8023297
to
5d43b9e
Compare
The new parameter allows to set a health check interval valid for all backends. Custom values set per provider may override the global one.
timoreimann
force-pushed
the
add-global-option-for-healthcheck-interval
branch
from
b2cbb8f
to
2534542
Compare
timoreimann
changed the base branch from
configure-healthcheck-via-marathon-label
to
master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new parameter allows to set a health check interval valid for all backends. Custom values set per provider may override the global one.
@containous/traefik Please review.