Add documentation about k8s Helm Chart #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoreimann
suggested changes
Mar 31, 2017
There was a problem hiding this comment.
Could you also please extend line 15 like
"Deploy Traefik using a Deployment object"
docs/user-guide/kubernetes.md
Outdated
| @@ -100,6 +100,16 @@ curl $(minikube ip) | |||
|
|
|||
| > We expect to see a 404 response here as we haven't yet given Træfɪk any configuration. | |||
|
|
|||
| ## Deploy Træfɪk using Helm Chart | |||
|
|
|||
| Install Træfɪk chart by: | |||
There was a problem hiding this comment.
Could you put in somewhat of a transition from the previous section by saying something like
"Instead of installing Traefik via a Deployment object, you can also use the Traefik Helm chart."
|
Seeing #1368, we should say Træfik instead of Træfɪk. |
|
Thanks you @timoreimann for the review. All changes done. |
timoreimann
approved these changes
Mar 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds information about the existence of a Helm Chart for traefik on the Kubernetes documentation.