Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make toml Bucket array homogeneous #1369

Merged
merged 1 commit into from
Mar 31, 2017
Merged

Make toml Bucket array homogeneous #1369

merged 1 commit into from
Mar 31, 2017

Conversation

Starefossen
Copy link
Contributor

@Starefossen Starefossen commented Mar 31, 2017 •
edited
Loading

This solves the following error:

Error reading TOML config file /etc/traefik/traefik.toml : Near line 24 (last key parsed 'web.metrics.prometheus.Buckets'): Array contains values of type 'Float' and 'Integer', but arrays must be homogeneous.

timoreimann
timoreimann approved these changes Mar 31, 2017
View reviewed changes
Copy link
Contributor

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's an important one. Thanks a lot!

vdemeester
vdemeester approved these changes Mar 31, 2017
View reviewed changes
Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐮

@timoreimann timoreimann removed the request for review from emilevauge March 31, 2017 12:46
@timoreimann timoreimann merged commit 35973f1 into traefik:master Mar 31, 2017
@ldez ldez added this to the 1.3 milestone May 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timoreimann timoreimann timoreimann approved these changes

@vdemeester vdemeester vdemeester approved these changes

Assignees
No one assigned
Labels
area/documentation area/middleware/metrics kind/enhancement a new or improved feature.
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
4 participants
@Starefossen @vdemeester @timoreimann @ldez