Fix default timeouts for Marathon provider. #1398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoreimann
changed the title
|
Marking WIP because I still want to add an integration test. |
timoreimann
force-pushed
the
fix-default-timeouts-for-marathon-provider
branch
from
b7b166f
to
788b661
Compare
timoreimann
force-pushed
the
fix-default-timeouts-for-marathon-provider
branch
3 times, most recently
from
ce23287
to
717cf17
Compare
|
I went down a huge rabbit hole trying to add an integration test. I decided to carve out the test into a separate PR #1406 and reduced this one. @emilevauge can we approve the PR without the extended test for now? I'd like the fix to be in first, will continue to work on the test. |
timoreimann
changed the title
|
Ping @emilevauge |
timoreimann
force-pushed
the
fix-default-timeouts-for-marathon-provider
branch
from
717cf17
to
bededab
Compare
timoreimann
force-pushed
the
fix-default-timeouts-for-marathon-provider
branch
2 times, most recently
from
a9594e2
to
360e8e1
Compare
The timeouts were given without a unit, which caused nanoseconds scale to be applied when we switched the type from int to flaeg.Duration.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timeouts were given without a unit, which caused nanoseconds scale to be applied when we switched the type from
inttoflaeg.Duration.Fixes a regression introduced by #1350.
Discovered along #1390.