Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract providers to their own packages #1444

Merged
merged 1 commit into from
Apr 18, 2017

Conversation

vdemeester
Copy link
Contributor

@vdemeester vdemeester commented Apr 16, 2017

Following #1440, this extracts the other provider to their own packages. Still refactoring to do (some stuff to un-export in k8s for ex, tests refactoring, etc..).

As it's based on #1440, only the last commit sholud be reviewed — and I'll rebase once it's merged 👼

Changes around : +840/-815

Copy link
Contributor

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments left on the commit.

Copy link
Contributor

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This is just doing that and making it compile :)

Signed-off-by: Vincent Demeester <[email protected]>
Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aswell 👼 Vincent on a run!

@vdemeester vdemeester merged commit f03a9e5 into traefik:master Apr 18, 2017
@vdemeester vdemeester deleted the extract-providers branch April 18, 2017 20:54
Prefix string `description:"Prefix used for KV store"`
TLS *provider.ClientTLS `description:"Enable TLS support"`
StoreType store.Backend
Kvclient store.Store
Copy link
Member

@emilevauge emilevauge Apr 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that's a good idea to have these fields exported. They will be added automatically to the flags traefik --help (to be verified).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emilevauge I don't see them in --help output. I guess it's only exported field that have the description:"…" thinguy 👼

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK thanks :) Is there any possibility to not export these fields in the future? Not really fond of this ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emilevauge yes, it is in my plan somehow 👼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants